-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate types with pyre and check with mypy 3.8 #214
Conversation
8d8c202
to
4c9bcde
Compare
Excited for this! |
810e694
to
4861f37
Compare
b8928ac
to
79ab057
Compare
About
The reason for not having a baseclass for the model class in Truss is that we didn't want the user truss to depend on an additional library, certainly not Truss. Bundling an extra class into the default truss takes away from the simplicity. Open to ideas. Perhaps when we carve out a smaller base library out of Truss, which could have this base class, we can have the user truss depend on it. |
Sounds good. Looking forward to chatting about some of this truss later today. I'm re-running integration tests here and optimistic they'll pass: https://github.com/basetenlabs/truss/actions/runs/4135323088/jobs/7147618276 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
What
Truss needs to be well typed for developer ergo and productivity. It's also very helpful for catching a lot of compile-type issues earlier that we can't do with python
How
mypy
to do type checkingNotes:
hasattr
stuff all over the placeTesting
The hope is the unit and integration tests catch everything here