-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop legacy Kserve input validation #219
Conversation
I think we also need to drop the part of validate function in model_wrapper, where we validate the input and raise InvalidInput error. We'd want to keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, good to add tests for the case where previously we would have done input validation.
I still worry about doing this on pre-process:
Do you think we can get away with only doing this for I think doing this for |
What
Kserve expects that inputs with the
inputs
orinstances
keyword to match up to being either a list or a numpy array. However, since we have moved to allow truss users to specify the input type to their predict function in a very flexible way, this legacy kserve behavior is incompatible and gets in the user's way by returning opaque 400 errors.This PR drops that input validation from kserve and passes the decoded input to the model's predict function directly. Any user errors are expected to return a 500 and to show the stacktrace in the logs of the service.