Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interactive cli truss watch, more informative logging, remove duplicate checks #473

Merged
merged 4 commits into from
Jul 25, 2023
Merged

interactive cli truss watch, more informative logging, remove duplicate checks #473

merged 4 commits into from
Jul 25, 2023

Conversation

joostinyi
Copy link
Collaborator

@joostinyi joostinyi commented Jul 25, 2023 •
edited
Loading

  • adds interactive cli experience, more informative logging on watch process, and removes model status checks that were migrated to the baseten application

@joostinyi joostinyi requested review from bolasim and removed request for bolasim July 25, 2023 17:00
@joostinyi joostinyi changed the title add more informative logging in watch process interactive cli truss watch, more informative logging, remove duplicate checks Jul 25, 2023
@joostinyi joostinyi requested a review from bolasim July 25, 2023 20:02
bolasim
bolasim approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can you just post a video of the new UX? would love to see it.

truss/contexts/local_loader/truss_file_syncer.py Show resolved Hide resolved
@joostinyi
Copy link
Collaborator Author

https://www.loom.com/share/e423984b280b489d98dbea84341a5727?sid=3be8b444-d8e8-4752-9004-c0a57c3ded28

@joostinyi joostinyi merged commit 2edfde4 into main Jul 25, 2023
@joostinyi joostinyi deleted the truss-watch-logging branch July 25, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolasim bolasim bolasim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joostinyi @bolasim