Simply integration and release workflows #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasim
changed the title
squidarth
approved these changes
Aug 4, 2023
aspctu
added a commit
that referenced
this pull request
Aug 7, 2023
* Add small note about how to push new truss version. (#501) * Simply integration and release workflows (#505) * Start refactor version detect into action * Resolve file * Should be working now * test integration tests too * Prepare for merge * Updating nginx filename (#506) * incrementing version (#507) --------- Co-authored-by: Sidharth Shanker <sid.shanker@baseten.co> Co-authored-by: Bola Malek <bola@baseten.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a separate release branch, we don't need to run the integration tests both in main and the release workflow. The release workflow should only be merged from main if main already passes the integration tests.
With that, we need to build the base images for the integration tests, which has now moved to main. Everything else just runs on release. The detection of versions was refactored into a reusable composite action.