Support remote predict #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasim
force-pushed
the
bola/truss-remote-predict
branch
from
806a084 to
ff33d5c
Compare
squidarth
approved these changes
Aug 9, 2023
| @@ -28,6 +28,11 @@ def exists_model(api: BasetenApi, model_name: str) -> Optional[str]: | |||
| return None | |||
|
|
|||
|
|
|||
| def get_model_versions_info(api: BasetenApi, model_name) -> Tuple[str, dict]: | |||
| query_result = api.get_model(model_name)["model_version"]["oracle"] | |||
There was a problem hiding this comment.
what happens if the model version doesn't exist anymore?
There was a problem hiding this comment.
yeah. I'll clean up the query
| if published: | ||
| for mv in model_versions: | ||
| if not mv["is_draft"]: | ||
| model_version = mv |
There was a problem hiding this comment.
what assumptions are we making about order here? what if there are multiple non-draft versions that get returned
There was a problem hiding this comment.
yeah. this needs to modify the query to sort by return time. I'll play around with the query a bit to get this right. I'd rather have a good graphql query that returns the right version instead of doing the post processing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.