Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vLLM documentation #573

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Fixed vLLM documentation #573

merged 4 commits into from
Aug 16, 2023

Conversation

varunshenoy
Copy link
Contributor

Updated predict dictionary to include model name --published`.

Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert pyproject.toml before merging

pyproject.toml Outdated
@@ -1,6 +1,6 @@
[tool.poetry]
name = "truss"
version = "0.6.0"
version = "0.5.7rc1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be bumped to 0.6.1

pyproject.toml Outdated
@@ -41,6 +41,7 @@ watchfiles = "^0.19.0"
huggingface_hub = "^0.16.4"
rich-click = "^1.6.1"
inquirerpy = "^0.3.4"
google-cloud-storage = "^2.10.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed here or just in builder?

pyproject.toml Outdated
@@ -1,6 +1,6 @@
[tool.poetry]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe revert this whole file for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call -- do you know why the tests here are failing though? Will be important for the gcs pr.

Varun Shenoy added 2 commits August 16, 2023 19:56
@varunshenoy varunshenoy merged commit 7716e54 into main Aug 16, 2023
@varunshenoy varunshenoy deleted the varun/vllm-docs branch August 16, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants