Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation for new Truss releases #578

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Conversation

squidarth
Copy link
Collaborator

@squidarth squidarth commented Aug 17, 2023

This is a WIP, but to test, I need to have this on the main branch unfortunately. The new flow for creating a Truss will be:

  1. Trigger the "Create Release PR" Github Action, and provide the new version ID. This will commit a new version to main and create a PR from a new branch w/ the new version to release (we will also commit the new release version number to main)
  2. Someone approves the release PR. It will have auto-merge on, so once it's approved & tests pass, it will get merged.

This is better because:

  • No PRs need to be created manually
  • Everything can be done from Github UI

@squidarth squidarth changed the title New create_release_pr github action. Automation for new Truss releases Aug 17, 2023
@squidarth squidarth marked this pull request as ready for review August 17, 2023 18:33
Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love it if it only commite back pyproject.toml to main after the PR created here is merged to release

@squidarth
Copy link
Collaborator Author

Would love it if it only commite back pyproject.toml to main after the PR created here is merged to release

Cool -- I'm gonna merge this now so I can iterate on it, but I'll look into if this is possible without causing a weird git history!

@squidarth
Copy link
Collaborator Author

@bolasim I think a good flow would be, once this PR is merged, we have another git action that listens for merges in release, and then simply merges back into master.

@squidarth squidarth merged commit 3455c31 into main Aug 18, 2023
@squidarth squidarth deleted the sshanker/gh-action-new-release branch August 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants