Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests workflow #596

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add integration tests workflow #596

merged 2 commits into from
Aug 21, 2023

Conversation

varunshenoy
Copy link
Contributor

Adds integration test workflow to the .github folder. It's the same as main.yml without the push to pypi.

@varunshenoy varunshenoy requested a review from bolasim August 21, 2023 22:07

on:
workflow_dispatch: # Allows running from actions tab
push:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this push please

@bolasim bolasim requested a review from joostinyi August 21, 2023 22:20
@varunshenoy varunshenoy merged commit 9ab0ae6 into main Aug 21, 2023
@varunshenoy varunshenoy deleted the varun/integration-action branch August 21, 2023 22:29
--python-version ${{ matrix.python_version }} \
--job-type ${{ matrix.job_type }} \
--version-tag ${{ needs.detect-version-changed.outputs.new_base_image_version }} \
--skip-login --push
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to potentially push base images when we run integration tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants