Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils to read s3 files #635

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

theshop
Copy link
Contributor

@theshop theshop commented Sep 5, 2023

Description:
This PR introduces a couple of s3 helper functions. One to download the file and the other to read the file as a stream of bytes. Assumes you have permissions already figured out with baseten.

@theshop theshop force-pushed the nikhil/add-s3-utils branch from e12d5b2 to b5d2351 Compare September 5, 2023 22:22
@theshop theshop marked this pull request as ready for review September 5, 2023 22:23
Copy link
Collaborator

@joostinyi joostinyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – thanks for putting up a PR

@joostinyi joostinyi merged commit 0865cf8 into basetenlabs:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants