Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BST-220] fix: datetime fields are sending updates on record update even when not needed #218

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

mihaimdm22
Copy link
Collaborator

Description

The problem happened bcs datetime field edit was sending a DateTime type value and the diff checker compared with the string value coming from db. The solution is to send the date as a string.

Fixes BST-220

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/basetool/basetool/GVkUmHwif8j9ftxqcW9DomNf7wpA
✅ Preview: https://basetool-git-fix-datetime-updates-on-record-update-basetool.vercel.app

@github-actions github-actions bot added the fix label Nov 10, 2021
@adrianthedev adrianthedev merged commit 4208ffa into main Nov 10, 2021
@adrianthedev adrianthedev deleted the fix/datetime-updates-on-record-update branch November 10, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants