Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect screen and return unsupported error #17

Merged
merged 5 commits into from
May 18, 2024
Merged

Detect screen and return unsupported error #17

merged 5 commits into from
May 18, 2024

Conversation

bash
Copy link
Owner

@bash bash commented May 17, 2024

See #16

@bash bash changed the title Separate quirks from core logic Write query to host terminal if running inside screen May 17, 2024
@bash
Copy link
Owner Author

bash commented May 17, 2024 •
edited
Loading

Todo:

  • I'm not particularly happy with write_to_host_terminal, maybe ask @janhohenheim if he has an idea?
  • Test what happens when no client is attached to screen
  • [ ] Maybe document terminal quirks in lib docs

@bash bash marked this pull request as ready for review May 18, 2024 16:52
@bash bash changed the title Write query to host terminal if running inside screen Detect screen and return unsupported error May 18, 2024
@bash bash merged commit 58dc870 into main May 18, 2024
7 checks passed
@bash bash deleted the screen branch May 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bash