Refresh efile port if gone #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test shows how if the cached efile port closes, our dumb ass can not recover and Bitcask is unable to open casks. Yeah.
When the efile port cached in the process dictionary dies for any reason, the code tries to load it one more time. If we can not open a new port, something is probably seriously wrong, so we stop. This fixes the issue with efile ports going away, then Bitcask basically getting stuck on the list_dir operation needed when opening a cask. The bitcask:efile_error_test/0 will now pass with this change.
|
@borshop +1 |
|
+1 |
|
+1 f947c2c |
borshop
added a commit
that referenced
this pull request
Sep 12, 2014
Refresh efile port if gone Reviewed-by: slfritchie
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the efile port cached in the process dictionary dies for any
reason, the code tries to load it one more time. If we can not open a
new port, something is probably seriously wrong, so we stop.
This fixes the issue with efile ports going away, then Bitcask basically
getting stuck on the list_dir operation needed when opening a cask, which
relies on this port to avoid serializing through the file_server.
The bitcask:efile_error_test/0 added in the first commit will fail, and pass in
the second commit.
This fixes #188