Fix scan error deadlock #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test demonstrates that when Bitcask's scan files operation fails, a keydir object is created, not marked ready and left behind. Subsequent open operations are unable to succeed because they try to wait for this existing keydir to be ready when its data loads. But this will never happen, so sadness ensues.
If a file scan error happens during a Bitcask open operation, remember to release the newly created keydir. Before, that keydir was left behind. Subsequent open operations would see it, see that it was not ready yet and try to wait for it to load. But this would never happen, alas. If a scan error happens on opening a new directory, please release the newly created keydir so other open operations have a chance to succeed.
|
+1 |
|
+1 4862bf6 |
borshop
added a commit
that referenced
this pull request
Sep 12, 2014
Fix scan error deadlock Reviewed-by: slfritchie
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file scan error happens during a Bitcask open operation, remember
to release the newly created keydir. Before, that keydir was left
behind. Subsequent open operations would see it, see that it was not
ready yet and try to wait for it to load. But this would never happen,
alas.
If a scan error happens on opening a new directory, please release the
newly created keydir so other open operations have a chance to succeed.
This fixes issue #187
The first commit contains a new failing tests to demonstrate, and the
second commit contains the fix.