Develop 3.0 mergerebar3 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thumbs targets succeed.
…tructure - relative paths no longer cut it.
…ut EQC. - Expands the list of Thumbs build steps for better coverage. - Adds actual application dependencies to .app.src for dialyzer goodness. - Adds missing record field type specs, also for dialyzer. - Cleans up remaining edoc errors.
…update git's merge pointer to avoid conflicts later.
Needs to produce script as expected by riak make rel
We have thumbs no more
|
I think cuttlefish is being pulled in (when making a release) from the kyorai fork via the rebar3_cuttlefish plugin, so we may need to bring that inline and merge with this at some point. |
|
It is @martincox branch of https://github.com/martinsumner/rebar3_cuttlefish/tree/develop-3.0 Will PR this into the basho version today. |
|
Ahh sound then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some work to tidy up cuttlefish in Ted's rebar3 branch. This work was required by the bitcask develop-3.0 branch to run its bitcask schema check unit tests.
I've merged in here, but ignoring most of the rebar.config changes (as the rebar3 branch didn't escriptize as expected a cuttlefish file).
There is an update to a
cuttlefish_rebar_pluginmodule - to make it rebar2 not rebar compatible - but this is not yet rebar3 compatible. I can't see anything using this module - so the lack of rebar3 support is hopefully not an issue.