Mv iter close fix #117
Merged
Mv iter close fix #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 17, 2014 08:14
… claims the close a tad more robust against known race condition.
…ially delete the same object (bad, matthew. bad, bad, matthew)
…void pointer so OSX would compile
|
+1 |
| @@ -954,7 +954,8 @@ async_close( | |||
| // verify that Erlang has not called DbObjectResourceCleanup | |||
| // already (that would be bad) | |||
| if (NULL!=db_ptr->m_Db | |||
| && compare_and_swap(db_ptr->m_ErlangThisPtr, db_ptr.get(), (DbObject *)NULL)) | |||
| // && compare_and_swap(db_ptr->m_ErlangThisPtr, db_ptr.get(), (DbObject *)NULL)) | |||
There was a problem hiding this comment.
any reason to leave commented code in?
There was a problem hiding this comment.
Awaiting next round of changes to clean up. With this bug, never completely sure if you are finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct race condition in asynchronous close logic that leads to segfaults. The bad code was merged to develop via the mv-tuning7 branch.
Detail discusssion is here: https://github.com/basho/leveldb/wiki/mv-iter-close-fix