Use the greater of operation or socket timeout #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t timeout is at least as long of a duration
| @@ -23,8 +22,7 @@ func integrationTestsBuildCluster() *Cluster { | |||
| var cluster *Cluster | |||
| var err error | |||
| nodeOpts := &NodeOptions{ | |||
| RemoteAddress: getRiakAddress(), | |||
| RequestTimeout: time.Second * 20, | |||
There was a problem hiding this comment.
This was "artificially" set to 20 secs to prevent socket timeouts. No longer necessary as the operation timeout will be used if it's greater than the socket timeout.
lukebakken
added a commit
that referenced
this pull request
Feb 19, 2016
…outs Use the greater of operation or socket timeout
|
👍 Looks good. Sorry for the delayed review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For commands that support an operation timeout, ensure that the socket timeout is at least as long of a duration.
Fixes #55 (CLIENTS-770)