Test for object existence using head request. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the PB head option or an HTTP HEAD request.
| true | ||
| rescue Riak::FailedRequest | ||
| rescue Riak::FailedRequest => e | ||
| raise e unless e.not_found? |
There was a problem hiding this comment.
Handling this exception correctly is excellent :)
|
Buller? |
|
Closing this; while it's applicable to HTTP users on 1.4 and earlier, HTTP support is going away in 2.0. |
|
@bkerley This is not just for HTTP. This is applicable to PB as well. See the PB API documentation. |
|
Good call on that. |
bkerley
added a commit
that referenced
this pull request
Sep 5, 2013
Test for object existence using head request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the PB head option or an HTTP HEAD request.