Fix homebrew source path #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,7 +208,7 @@ def configure_settings | |||
|
|
|||
| # Sets the source directory and root directory of the generated node. | |||
| def configure_paths | |||
| @source = Pathname.new(configuration[:source]).expand_path | |||
| @source = Pathname.new(configuration[:source] + '/riak').realpath.parent | |||
There was a problem hiding this comment.
The script name is not guaranteed to be riak (0.14 and earlier might have riaksearch).
|
I've resolved this slightly differently. |
|
@seancribbs Sounds good. Thanks for the response. |
|
Please check that the version on master works for you (just merged tonight). On Apr 3, 2012, at 8:31 PM, Gordon Wilsonreply@reply.github.com wrote:
|
|
Yup, 86a3e66 works for me. Thanks |
|
Great, with a few more fixes we should be able to release again soon. On Apr 3, 2012, at 9:38 PM, Gordon Wilsonreply@reply.github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #26.
In test_server.yml.example the source path for homebrew is "/usr/local/bin".
With this change that example path works. Otherwise the full libexec path is needed, e.g., "/usr/local/Cellar/riak/1.1.1x86_64/libexec/".