Fix late registrations: riak_api_pb_server is no longer a gen_server #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes 'unrecognized message' bugs found in http://giddyup.basho.com/#/projects/riak/scorecards/60/60-1324-yz_siblings-ubuntu-1004-64/28410/artifacts/382221 |
|
@rzezeski Could you review this, given you originally reported the issue? |
|
Yea I should be able to check this on my next riak test run. |
|
Awesome, thanks! |
|
I no longer see the unrecognized messages and the code looks good. +1 to merge. |
seancribbs
pushed a commit
that referenced
this pull request
Dec 18, 2013
Fix late registrations: riak_api_pb_server is no longer a gen_server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
gen_fsm:send_all_state_event/2instead ofgen_server:cast/2.