Teach riak_core Bucket Types #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like buckets, we must teach core this because a few subsystems use them. Bucket Types provide a method for grouping buckets logically (see basho/riak#362).
… reset Non-default bucket-types are unaffected by changes to app.config and bucket types can have their properties reset to the hardcoded defaults.
ghost
assigned 
| resolve({notfound_ok, NF1}, {notfound_ok, NF2}) -> | ||
| NF1 orelse NF2; | ||
| resolve({old_vclock, Old1}, {old_vclock, Old2}) -> | ||
| case Old1 > Old2 of |
There was a problem hiding this comment.
This and all the other resolution cases would be more readable long term if we used good ol' max() instead IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like buckets, we must teach core this because a few subsystems use them. Bucket Types provide a method for grouping buckets logically (see basho/riak#362).
This PR requires Cluster Metadata which can be found on https://github.com/basho/riak_core/tree/corekv-unstable and https://github.com/basho/riak_core/tree/jrw-cluster-meta. This PR should not be merged until Cluster Metadata has the +1 and is merged as well.