Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored riak_core bits of the schema in here, with tests #417

Merged
merged 2 commits into from
Oct 9, 2013

Conversation

joedevivo
Copy link
Contributor

Although the rebar.config specifies cuttlefish:develop, it will need jd-test-tools to run until basho/cuttlefish#42 is merged. If you do review this, be a dear and review that too? :)

I've refactored the riak_core bits of the schema into the riak_core project for easier testing and less duplication of schema files between the riak and riak-ee repos..

@@ -0,0 +1,68 @@
-module(riak_core_schema_tests).

-include_lib("eunit/include/eunit.hrl").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing an -ifdef(TEST)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we didn't bother with -ifdef(TEST) for modules in the test dir

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrwest
Copy link
Contributor

jrwest commented Oct 9, 2013

Going to go ahead w/ the +1 now since any changes are just comments and maybe an ifdef. Tests run as part of make test and pass for me. Schema looks good. I mentioned to @joedevivo elsewhere that there are some riak_core application config vars we probably want to add the to schema, but those can be added separately (we should open an issue though).

+1 merge.

joedevivo added a commit that referenced this pull request Oct 9, 2013
refactored riak_core bits of the schema in here, with tests
@joedevivo joedevivo merged commit 2ec217c into develop Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants