Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dvv_enabled=true to default props for typed buckets #568

Merged
merged 1 commit into from
Apr 4, 2014

Conversation

russelldb
Copy link
Member

Even though this is a kv only option

@russelldb russelldb added this to the 2.0-RC milestone Apr 4, 2014
@russelldb
Copy link
Member Author

Assigned you @cmeiklejohn, since we discussed this approach yesterday.

@cmeiklejohn
Copy link
Contributor

👍 if there is no other way.

@russelldb
Copy link
Member Author

@cmeiklejohn it's bors'd, please to be +1'ing a hash

@cmeiklejohn
Copy link
Contributor

👍 cf0972d

borshop added a commit that referenced this pull request Apr 4, 2014
Add `dvv_enabled=true` to default props for typed buckets

Reviewed-by: cmeiklejohn
@russelldb
Copy link
Member Author

@borshop merge

@borshop borshop closed this Apr 4, 2014
@borshop borshop deleted the rdb/dvv-bucket-prop branch April 4, 2014 20:32
@borshop borshop merged commit cf0972d into develop Apr 4, 2014
@jrwest
Copy link
Contributor

jrwest commented Apr 4, 2014

i realized we didn't have an issue to track the awful thing that is hardcoded bucket type defaults. no longer: #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants