-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ceph tests to the latest version. #1096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #1085 (RCS-134). |
Not a bug of this pull request, but I'd like this patched: diff --git a/client_tests/python/boto_tests/boto_test.py b/client_tests/python/boto_tests/boto_test.py
index dbfa39c..bfbef4c 100755
--- a/client_tests/python/boto_tests/boto_test.py
+++ b/client_tests/python/boto_tests/boto_test.py
@@ -33,6 +33,8 @@ import boto
def setup_auth_scheme():
auth_mech=os.environ.get('CS_AUTH', 'auth-v2')
+ if not boto.config.has_section('s3'):
+ boto.config.add_section('s3')
if auth_mech == 'auth-v4':
setup_auth_v4()
else:
@@ -41,13 +43,11 @@ def setup_auth_scheme():
def setup_auth_v4():
print('Use AWS Version 4 authentication')
if not boto.config.get('s3', 'use-sigv4'):
- boto.config.add_section('s3')
boto.config.set('s3', 'use-sigv4', 'True') This code conflicted with my |
I'll do +1 if above patch merged. Good job. |
all r_t has passed |
borshop
added a commit
that referenced
this pull request
Mar 20, 2015
Update ceph tests to the latest version. Reviewed-by: kuenishi
@borshop merge |
@ksauzz Pleas list up all issues found via your work here. |
|
Thanks (thumbup) |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basho/s3-tests#2 is needed to pass the tests.