Feature/ bag support #853
Closed
Feature/ bag support #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because bucket records are used in user recoreds stored in Riak, introducing its new version requires rolling upgrade of all riak-cs nodes with cs_version trick. rcs_bucket_v2 had the additional field "manifest_bag", which is used only in storage calculation. In storage calculation, bucket objects fetch are added and bag_id's are now extracted from them. This adds some GET calls to Riak but they are much less costly compared to map-reduce.
tools.mk.git at commit e631fca1fd366461022e108315dac6032d1c36fb
…onment - confirming no active manifests and - deleting MP-initiated manifests
This was referenced May 20, 2014
| @@ -61,7 +90,7 @@ case UseEEDeps of | |||
| {package_install_user, \"riakcs\"}. | |||
| {package_install_group, \"riak\"}. | |||
| {package_install_user_desc, \"Riak CS user\"}. | |||
| {package_commands, {list, [[{name, \"riak-cs\"}], [{name, \"riak-cs-access\"}], [{name, \"riak-cs-gc\"}], [{name, \"riak-cs-storage\"}], [{name, \"riak-cs-stanchion\"}], [{name, \"riak-cs-cinfo\"}], [{name, \"riak-cs-debug\"}]]}}. | |||
| {package_commands, {list, [[{name, \"riak-cs\"}], [{name, \"riak-cs-access\"}], [{name, \"riak-cs-gc\"}], [{name, \"riak-cs-storage\"}], [{name, \"riak-cs-stanchion\"}], [{name, \"riak-cs-cinfo\"}], [{name, \"riak-cs-debug\"}], [{name, \"riak-cs-multibag\"}]]}}. | |||
There was a problem hiding this comment.
This line will conflict against riak-cs-admin patch.
| [Pid]; | ||
| start_block_servers(RiakcPid, MaxNumServers) -> | ||
| case start_link() of | ||
| -spec start_block_servers(lfs_manifest(), pid(), pos_integer()) -> [pid()]. |
There was a problem hiding this comment.
Maybe a good chance to rename this function .
|
Close this in favor of #870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable multibag feature.