add is_crdt convenience fn

[zeeshanlakhani]

Convenience fun related to @seancribbs's comment on basho/yokozuna#452 (diff). If there's a better name for this fun, I'll update it accordingly :).

[russelldb]

Why the case statement and not just:

BProps = riak_core_bucket:get_bucket(Bucket),

?

[zeeshanlakhani]

I kinda stole most of this from https://github.com/basho/riak_kv/blob/feature/zl/helper-fn-check-if-object-bucket-props-supports-crdt/src/riak_kv_crdt.erl#L103 haha, which probably has it just for the guard. But, you're right, the case is unnecessary.

[zeeshanlakhani]

Looking at other spots, e.g.

riak_kv/src/riak_kv_util.erl

Line 163 in ec7e525

-spec consistent_object(binary() | {binary(),binary()}) -> true | false | {error,_}.

, I decided to keep the case, but actually have an error case if BProps is not a list for some reason.

[russelldb]

Looks good to me, although a unit test wouldn't hurt.

[zeeshanlakhani]

Yeah... I'm basically testing it for the use-case here, https://github.com/basho/yokozuna/pull/452/files#diff-a765b250cdc4d78ac1eef6cfddbbb280R508, but I'll add a unit test.

[russelldb]

Thanks, I think a unit test here is needed. Just something simple, meck out riak_core_bucket and return buckets for all the datatypes, some datatype=nonsense, and some no datatype is exhaustive.

[seancribbs]

👍 9f17bcc

[zeeshanlakhani]

@borshop merge