reset bucket props via http #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DELETE /buckets/Bucket/props * no support for vsn 1 api
| %% | ||
| %% DELETE /buckets/Bucket/props | ||
| %% Reset bucket properties back to the default settings | ||
| %% not supporteed by the OLD API |
ghost
assigned
| @@ -208,6 +217,12 @@ accept_bucket_body(RD, Ctx=#ctx{bucket=B, client=C, bucketprops=Props}) -> | |||
| {{halt, 400}, RD2, Ctx} | |||
| end. | |||
|
|
|||
| %% @spec delete_resource(reqdata(), context()) -> {boolean, reqdata(), context()} | |||
There was a problem hiding this comment.
FYI I realize it's out-of-scope for this PR but in all other places we tend to use the newer -spec rather than the %% @spec form. The origins of this file are old enough to have used the comment form, so let's consider that a janitorial task for later.
There was a problem hiding this comment.
yea I noticed @rzezeski made a similar comment on the original implementation. Figured it best to not change it over as part of this PR like you said.
|
merging (+1 here for reference since gh wasn't able to make the association) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the functionality in basho/riak_core#248 over the version 2 HTTP API.
Depends on: basho/riak_core#248
Original Implementation: #357