Add support for conditional postcommit hooks #771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for conditional postcommit hooks. Currently, these
are implemented solely for typed buckets, but may be expanded to untyped
buckets in the future.
This addition is motivated by the lack of support for "bucket fixups" for
typed buckets. For traditional buckets, fixups are the primary mechanism
used in Riak to ensure hooks are installed on buckets as necessary.
Unlike traditional postcommits hooks, that are registered per-bucket,
conditional hooks are registered globally (per node). Each time a PUT is
triggered, all registered conditional postcommit hooks are triggered. The
hook function is passed the relevant bucket, key, and bucket properties and
should return either false or a list of postcommit hooks that should be
triggered. If any hooks are returned, they are invoked the same as normal
postcommit hooks.
Test pull-request: basho/riak_test#485