Move metadata settings to advanced level. #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likely to play with it. as written it is hard to make it improve performance in a predictable way.
|
Same generated value before and after change, only difference is the metadata_cache_size is not visible in the riak.conf file. 👍 |
evanmcc
added a commit
that referenced
this pull request
Feb 19, 2014
Move metadata settings to advanced level.
|
This did not get CSE/PM approval. 😦 |
|
shrug It should have never been in there in the first place, since the feature |
|
It was discussed on the Core/KV mumble and I think GregB was there. But I could have remembered wrong. @seancribbs did it break something? |
|
@jonmeredith Nope, just wanted to be sure the process was clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move md cache cuttlefish tunings into advanced so people are less
likely to play with it. as written it is hard to make it improve
performance in a predictable way.