Use iterator_refresh backend option for some folds #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add iterator_refresh capability to riak_kv_elveldb_backend and riak_kv_multi_backend * Handle iterator_refresh option/capability for ?FOLD_REQs in riak_kv_vnode * support iterator_refresh option for AAE (riak_kv_index_hashtree) * add riak_kv_vnode:fold/4 * return handoff fold options from handoff_started * handoff_started has been modified to require this * Get value of iterator_refresh from env. Default to true.
|
Replaces #830 . See that for discussion. |
|
re-iterating my +1. any |
|
|
||
| %% @private | ||
| maybe_enable_iterator_refresh(Capabilities, Opts) -> | ||
| case lists:member(iterator_refresh, Capabilities) of |
There was a problem hiding this comment.
fwiw, we could have dumped the config check in here instead of in two places but meh
andrewjstone
added a commit
that referenced
this pull request
Feb 21, 2014
Use iterator_refresh backend option for some folds
This was referenced Feb 21, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riak_kv_multi_backend
riak_kv_vnode