compile in 17.0: clients are compiles with various OTP versions

[kuenishi]

No description provided.

[seancribbs]

Isn't this type invalid on releases < 17.0? Furthermore, dict:dict/0 is the type in previous releases, not dict:dict/2.

[kuenishi]

Yes, it's invalid. I'll fix it in the following commit by introducing a sad version-specific switch. And to give nowarn_... to dialyzer we have to modify tools.mk, which probably we hope to be same across all our repositories?

[seancribbs]

No, you can specify the flags to use in the DIALYZER_FLAGS variable: https://github.com/basho/tools.mk/blob/master/tools.mk#L17

[seancribbs]

I'd rather see this include a version-specific switch so that our specs can be valid on both releases.

[seancribbs]

Example, on R16B02-basho4:

Unknown types:
  dict:dict/2

[evanmcc]

Isn't there a way to disable the warning for now?

[seancribbs]

@evanmcc We're not dialyzer-clean anyway on riak_pb. It hardly matters, except that it might break compilation.

[evanmcc]

Right, I was thinking about supressing the warning to get it to compile for
now, to work around erlang's horrible multi-version support.

[kuenishi]

In riak_pb, we can do without any error supressing because I added some horrible version-switch :sadpanda:

[kuenishi]

I tried passing the same options to Dialyzer but didn't worked.

DIALYZER_APPS = kernel stdlib sasl erts eunit ssl tools crypto \
       inets public_key syntax_tools compiler
DIALYZER_FLAGS = -Wnowarn_deprecated_type
include tools.mk

Which concequnced as follows (with R16B03-1):

...
==> riak-erlang-client (dialyzer)

dialyzer: Unknown dialyzer warning option: nowarn_deprecated_type

So my opinion is to go with ugly version switch by rebar.config.script .

[seancribbs]

@kuenishi I concur!

[kuenishi]

So the current state of pull request already includes version switch script. Any more thing to be done?

[seancribbs]

@kuenishi Just manual testing.

[seancribbs]

👍 to merge