Handle synchronous events for rolling upgrades. #601
Conversation
This reverts commit add831d.
cmeiklejohn
changed the title
cmeiklejohn
changed the title
|
I have determined the issue plaguing the We should investigate why attempting to cancel fullsync when it is not running causes this problem, but in my view that seems like a separate and less severe issue. |
| %% Unknown event (ignored) | ||
| wait_for_partition(Event, State) -> | ||
| lager:debug("Full-sync with site ~p; ignoring event ~p", | ||
| [State#state.sitename, Event]), | ||
| {next_state, wait_for_partition, State}. | ||
|
|
||
| build_keylist(Command, State) | ||
| when Command == cancel_fullsync -> | ||
| build_keylist(Command, State) when Command == cancel_fullsync -> |
There was a problem hiding this comment.
I know this is preexisting cruft, but the guards here could be eliminated in favor an explicit pattern match on the Command atoms and would make the code a bit more clear and concise.
There was a problem hiding this comment.
Looking closer I see that a similar pattern is used throughout this module so perhaps it is not worth worrying about at this time.
|
These changes look good and in concert with the riak_test PR mentioned above it resolves the 👍 |
Handle synchronous events for rolling upgrades. Reviewed-by: kellymclaughlin
|
@borshop merge |
Add handling for synchronous events, related to #600. However, I can't get replication_upgrade to get past the following:
@kellymclaughlin do you mind running?