Enhance/krab/cluster realtime rebalance rebase 2.0 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixen
force-pushed
the
enhance/krab/cluster-realtime-rebalance-rebase-2.0
branch
2 times, most recently
from
e1935d9 to
dbc6585
Compare
|
Now it works with mixed clusters. Tested with a RT only replication2_upgrade. |
|
This is a fix for - basho/riak#625 _[posted via JIRA by Derek Somogyi]_ |
|
👍 dbc6585 Mixed version test is no more broken than against the 2.0 branch. |
This implementes riak_core_cluster_serv {1,1}
with new membership function on the server side
to give list of {node(), {IP,Port} | unreachable}
for *all* members of remote cluster. Nodes for
which the cluster_serv cannot RPC to the given
node yield ‘unreachable’ in stead of an IP/Port.
Use new all_members message if remote is 1,1+ For 1,0 emulate new semantics by keeping old IP:PORTs around until cluster_mgr restart. Implement new seeded sort+shuffle for result of calling cluster_mgr:get_ipaddrs_of_cluster/1.
The first tells the caller the address currently connected to. The second tells the rtsource_conn to try (if possible) to switch to an alternative connection.
Possible to lose some addresses when ConnectedAddr are early in the list.
[{"127.0.0.1",10106},{"127.0.0.1",10066},{"127.0.0.1",10096},{"127.0.0.1",10076},{"127.0.0.1",10086}], ConnectedAddr: {"127.0.0.1",10066}
[{"127.0.0.1",10106}], UsefulAddrs [{"127.0.0.1",10106}]
Stats function now never returns error code.
lordnull
force-pushed
the
enhance/krab/cluster-realtime-rebalance-rebase-2.0
branch
from
dbc6585 to
5573645
Compare
|
Force pushed so yet another pull request doesn't have to come in after a rebase. |
|
👍 5573645 Once more with feeling. |
borshop
added a commit
that referenced
this pull request
Jan 22, 2015
…lance-rebase-2.0 Enhance/krab/cluster realtime rebalance rebase 2.0 Reviewed-by: lordnull
|
lordnull
deleted the
enhance/krab/cluster-realtime-rebalance-rebase-2.0
branch
|
According to the PR notes - #651 The PR has been reviewed and approved. Closing this issue. _[posted via JIRA by Derek Somogyi]_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and some squash of #632.
Will start looking at mixed cluster tests as @lordnull proposed.