Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding aae test for ts based on verify_aae #1259

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

korry8911
Copy link
Contributor

@javajolt passes for me locally

@@ -0,0 +1,401 @@
%% -------------------------------------------------------------------
%%
%% Copyright (c) 2013 Basho Technologies, Inc.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017?

%%
%% -------------------------------------------------------------------
%% @doc Verification of Active Anti Entropy.
%% The basic guarantee of AAE is this: Even without the read repairs that will
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the text a bit to mention that this is for time series

@hazen
Copy link

hazen commented Jan 11, 2017

@korry8911 Can you close this PR and submit a new one on develop? Thanks

@hazen hazen changed the base branch from riak_ts-develop to integration January 13, 2017 17:18
end, PlCounts, Pl).

test_data_ts(Start, End) ->
StepSize = 1000*60*5,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a comment about what this StepSize is and why we have it?

write_data_ts(Node, KVs, Table, _Opts) ->
[begin
O =
case ts_ops:get([Node], Table, key_ts(TS_Data_Tuple)) of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we reading the data first? In the verify_aae case they read in case the data already exists and update it instead. In TS, it is write-once and we never update values.

@hazen hazen changed the base branch from integration to develop February 3, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants