Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create verify_repl_deleteonfail.erl #1381

Open
wants to merge 1 commit into
base: develop-3.0
Choose a base branch
from

Conversation

martinsumner
Copy link

@martinsumner martinsumner commented Aug 8, 2023

%%
%% -------------------------------------------------------------------
%% @doc When replicating deletes, if a node is down in the cluster, clusters
%% will get out of sync, unless the deletion of tombstones is deferred when

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
%% will get out of sync, unless the deletion of tombstones is deferred when
%% will get out of sync, unless the deletion of tombstones is deferred as long as

hd(Nodes), <<"B1">>, lists:seq(1, ?NUM_KEYS_PERNODE * length(Nodes))),
lager:info("Delete attempts completed"),
wait_for_queues_to_drain(Nodes -- [FiddlingNode], cluster_b),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly spoken, from the function name "wait_for_queues_to_drain", I cannot confirm here that the tombstones are deferred... Some observation of that fact after a certain time would make this test indeed show the point.

Most likely just a matter of some additional explanation on what is happening here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants