Feature/stats2

[kuenishi]

• Add Riak access stats, mochiweb stats and system stats
• Some code cleanup

[shino]

Two blank lines.

[shino]

Will some tests come in the next round?

[kuenishi]

Those tests will be in riak_cs repo as integration test. Fair?

[shino]

Yup. Just want there be an issue or jira ticket for that (to cover my poor memory).

[shino]

Great eliminator 🔥

[shino]

The module stanchion_wm_buckets is used from velvet but not used from riak cs.
There is another PR for riak cs to merge velvet, so it seems good time to
delete the API completely.

Suggestion:

• Remove stanchion_wm_buckets.erl
• Then stanchion_utils:get_buckets() will be unused,
  get_value() in stanchion_utils will be unused.
  At last, [riakc, get_manifest] stats key can be removed in get_value function
  and stats definition in stanchion_stats.
• Remove velvet:list_buckets() in velvet merge PR to cs

[shino]

There was one wrong point in the above comment. [riakc, get_manifest] is used in other parts, can not be removed.

[shino]

Existing r_t caches typo 😹

Error log was as follows:

2015-07-23 11:41:42.343 [debug] <0.224.0>@stanchion_wm_bucket:delete_resource:123 Bucket: <<"riak-test-bucket">> Requester: <<"FSUNXVTYOMMTSX3Z_XJX">>
2015-07-23 11:41:42.345 [debug] <0.207.0>@stanchion_stats:update:95 Updating [riakc,get_cs_bucket] (1139)
2015-07-23 11:41:42.349 [debug] <0.207.0>@stanchion_stats:update:95 Updating [riakc,list_all_manifest_keys] (4026)
2015-07-23 11:41:42.350 [debug] <0.207.0>@stanchion_stats:update:95 Updating [riakc,get_manifests] (1005)
2015-07-23 11:41:42.350 [error] <0.207.0>@stanchion_utils:do_bucket_op:558 Error on updating bucket riak-test-bucket: {error,{badmatch,{error,not_found}}}
2015-07-23 11:41:42.350 [debug] <0.224.0>@stanchion_server:delete_bucket:105 [bucket,delete] {error,{error,{badmatch,{error,not_found}}}} 7580
2015-07-23 11:41:42.351 [debug] <0.224.0>@stanchion_stats:update:95 Updating [bucket,delete] (7580)
2015-07-23 11:41:42.358 [error] <0.224.0> Webmachine error at path "/buckets/riak-test-bucket" : {error,function_clause,[{stanchion_response,status_code,[{error,{badmatch,{error,not_found}}}],[{file,"src/stanchion_response.erl"},{line,65}]},{stanchion_response,api_error,3,[{file,"src/stanchion_response.erl"},{line,85}]},{webmachine_resource,resource_call,3,[{file,"src/webmachine_resource.erl"},{line,186}]},{webmachine_resource,do,3,[{file,"src/webmachine_resource.erl"},{line,142}]},{webmachine_decision_core,resource_call,1,[{file,"src/webmachine_decision_core.erl"},{line,48}]},{webmachine_decision_core,...},...]}

[shino]

Finished first round of review. Overall diff seems nice, bunch of code deletion is great 🏆
Will run r_t after comments are addressed.

[kuenishi]

Updated. Will run r_t with cs#1197, too.

[kuenishi]

Woops, updated

[kuenishi]

Fmm, many riak_test are failing with 500 ... cannot be merged yet.

[kuenishi]

Yay!

0 Tests Failed
34 Tests Passed
That's 100.0% for those keeping score

real    101m38.407s
user    15m54.576s
sys     3m42.104s

[shino]

💪