fix to java w/ version update and update to aae/pb tests for RIAK-1557 i... #459
Conversation
zeeshanlakhani
force-pushed
the
bugfix/zl/fix-for-entropy-data-with-spaces
branch
from
b75e042 to
5c719b3
Compare
|
@seancribbs I uploaded yokozuna-2.jar and yokozuna-2.jar.sha to S3. |
| @@ -9,6 +9,7 @@ | |||
| -include_lib("basho_bench/include/basho_bench.hrl"). | |||
| -record(state, {default_field, fruits, pb_conns, index, bucket, iurls, surls}). | |||
| -define(DONT_VERIFY, dont_verify). | |||
| -define(SPACER, 'foo '). | |||
There was a problem hiding this comment.
Total nitpick, but mind switching the prefix on space testing keys to something that makes the purpose clear if you're tracking down a problem later?
…7 involving entropy data and spaces in types/buckets/keys
zeeshanlakhani
force-pushed
the
bugfix/zl/fix-for-entropy-data-with-spaces
branch
from
5c719b3 to
9720f05
Compare
| run(load_fruit_plus_spaces, KeyValGen, _, S=#state{iurls=URLs}) -> | ||
| Base = get_base(URLs), | ||
| {Key, Val} = KeyValGen(), | ||
| Key2 = mochiweb_util:quote_plus(lists:concat([?SPACER, Key])), |
There was a problem hiding this comment.
Does this even work? ?SPACER is an atom.
There was a problem hiding this comment.
It does... but should I just make it a string?
There was a problem hiding this comment.
list_to_binary(lists:concat([' foo bar', binary_to_integer(<<"44">>)])).would then return <<" foo bar44">>... which would get formatted correctly on the url calls.
There was a problem hiding this comment.
string works too... so whichever is preferred :D.
There was a problem hiding this comment.
I think a string would be less surprising, that's all.
zeeshanlakhani
force-pushed
the
bugfix/zl/fix-for-entropy-data-with-spaces
branch
from
9720f05 to
ca768f3
Compare
|
👍 ca768f3 |
…h-spaces fix to java w/ version update and update to aae/pb tests for RIAK-1557 i... Reviewed-by: seancribbs
|
@borshop merge |
...nvolving entropy data and spaces in types/buckets/keys.
This fixes up the issue w/ Entropy Data described in #450 and #436.