Zl/handle and expose solr request timeout config and prevent crashes #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py_data request_handler test * make ping HEAD request and make sure build true is not sent async if we cannot ping solr on iteration
zeeshanlakhani
force-pushed
the
zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes
branch
2 times, most recently
from
c10b818 to
97960b6
Compare
zeeshanlakhani
force-pushed
the
zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes
branch
from
eb9423c to
0808117
Compare
|
|
||
| -spec write_objs([node()], bucket()) -> ok. | ||
| write_objs(Cluster, Bucket) -> | ||
| lager:info("Writing 1000 objects"), |
There was a problem hiding this comment.
I'd prefer to have the number of objects be a parameter to the function instead of hard coded. Maybe there could be a write_objs/3 that takes the parameter and write_objs/2 could call that function with 1000 as an argument?
There was a problem hiding this comment.
Sure.. I was just keeping w/ what we had, but sure.
zeeshanlakhani
force-pushed
the
zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes
branch
from
9b48994 to
96ca5f2
Compare
|
👍 96ca5f2 |
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Oct 14, 2015
…timeout-config-and-prevent-crashes Zl/handle and expose solr request timeout config and prevent crashes Reviewed-by: jvoegele
|
@borshop merge |
JeetKunDoug
deleted the
zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JeetKunDoug @fadushin
Related to Riak-2068.
entropy_dataSolr request to preventtimedoutcrash during iteration or allowing the build to pass if an error occurs in iterating over the tree or if solr was not pingable.solr_request_timeoutconfigurable, which is used by all Solr localhost http request and add macro timeout toentropy_datacall.After some testing around, I'd like to bring-in some of these "new work" changes for 2.1.2, and a new test, since we'll be testing the release again. I think they are minor, but go along w/ the cover + java/ed/base64 changes we've already added.
Tell me if I'm wrong, but I think this is a win-win and worth it. No others, otherwise :).
Even though, we're working through #565, I will backport/cherry-pick (-x) these for 2.0 after review for clarity.