lint: collect unused l10n tokens #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smelukov
commented
Jun 22, 2017
•
smelukov
commented
added 9 commits
June 20, 2017 18:35
smelukov
force-pushed
the
unused-l10n-tokens
branch
from
39ac758
to
779caa6
Compare
lahmatiy
reviewed
Jun 28, 2017
lib/lint/unused/l10n.js
Outdated
| if (!tokenNames[tokenName]) { | ||
| flow.warn({ | ||
| file: dictFileName, | ||
| message: tokenName |
There was a problem hiding this comment.
Should be something useful, e.g. Path ${tokenName} is never used
| { | ||
| var tokenNames = unusedL10nTokens[dictFileName]; | ||
|
|
||
| dictFileName = dictFileName.slice(process.cwd().length); |
There was a problem hiding this comment.
require('path').relative(process.cwd(), dictFileName)?
FileName -> Filename
| }); | ||
| } | ||
|
|
||
| tasks.push(task); |
There was a problem hiding this comment.
tasks.push({
name: 'unused l10n tokens at ' + dictFileName,
warnings: Object.keys(tokenNames).map(function(name) {
return { file: name };
})
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.