Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the learners_file and pass learners directly #39

Merged
merged 27 commits into from
May 20, 2020
Merged

remove the learners_file and pass learners directly #39

merged 27 commits into from
May 20, 2020

Conversation

basnijholt
Copy link
Owner

@basnijholt basnijholt commented Apr 9, 2020 •
edited
Loading

This is currently blocked by

With the code of this PR one can do:

run_manager = adaptive_scheduler.server_support.RunManager(
    scheduler=scheduler,
    learners=learners,
    fnames=fnames,
    goal=goal,
)

@basnijholt basnijholt force-pushed the remove-learners-file branch from 744a804 to 46cb844 Compare April 14, 2020 13:51
@lgtm-com
Copy link

lgtm-com bot commented Apr 14, 2020

This pull request introduces 1 alert when merging 46cb844 into 6eb8aba - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@basnijholt basnijholt force-pushed the remove-learners-file branch from ca933c1 to 704a949 Compare April 16, 2020 10:56
@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2020

This pull request introduces 1 alert when merging 524915a into 6eb8aba - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@basnijholt basnijholt force-pushed the remove-learners-file branch 2 times, most recently from 9deb9e0 to 1549a03 Compare April 21, 2020 14:10
@basnijholt basnijholt mentioned this pull request Apr 23, 2020
Merged
6 tasks
@lgtm-com
Copy link

lgtm-com bot commented May 14, 2020

This pull request introduces 1 alert when merging dcf1ac5 into a0a30ef - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@basnijholt basnijholt force-pushed the remove-learners-file branch from dcf1ac5 to f6c42ee Compare May 18, 2020 21:23
@lgtm-com
Copy link

lgtm-com bot commented May 18, 2020

This pull request introduces 1 alert when merging f6c42ee into 9d925e1 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@basnijholt basnijholt force-pushed the remove-learners-file branch from f6c42ee to a3d9ba7 Compare May 19, 2020 10:43
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request introduces 1 alert when merging 05a3334 into 76498bc - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

basnijholt added 17 commits May 19, 2020 12:16
@basnijholt
remove the learners_file and pass learners directly
4b90053
@basnijholt
attempt to fix "zmq.error.Again: Resource temporarily unavailable"
3046ad6
@basnijholt
use cloudpickle and send_serialized and recv_serialized
5296cb4
@basnijholt
use loky for process-pool
eb92364
@basnijholt
add loky as dependency
3494a1e
@basnijholt
fix doc-string and types of get_learner
d84404e
@basnijholt
use jinja2 for run_script.py
b5c8831
@basnijholt
add check_goal_on_start argument to RunManager
2212dd3
@basnijholt
only accept fnames to be of str because it failed with BalancingLearner
0a0e939
@basnijholt
add copy_from_sequence_learner
12b4ed7
@basnijholt
increase timeout to receive learner to 60s
e156473
@basnijholt
avoid file note found error in log parser
6d305a6
@basnijholt
make sure _stop_request gets an existing fname
24a7b8b
@basnijholt
always use strings for fnames
49703ed
@basnijholt
fix _get_fnames(only_running=True)
bc76101
@basnijholt
add _stop_requests to handle a list of fnames
b3e1d82
@basnijholt
rename serialize, deserialize -> _serialize, _deserialize
68ff2ed
@basnijholt basnijholt force-pushed the remove-learners-file branch from 05a3334 to 848af86 Compare May 19, 2020 12:16
@basnijholt basnijholt mentioned this pull request May 19, 2020
Closed
@basnijholt basnijholt changed the title WIP: remove the learners_file and pass learners directly remove the learners_file and pass learners directly May 19, 2020
@basnijholt basnijholt merged commit 2a67e37 into master May 20, 2020
@basnijholt basnijholt deleted the remove-learners-file branch May 20, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@basnijholt