Added signalling errors where appropriate. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 31, 2020 18:09
'annotate-load-annotation-data'.
…load-annotation-data-ignore-errors'. The existing code relies on the fact that a non existing database file can be considered as an empty database, wrote a wrapper of 'annotate-load-annotation-data' to keep the old behaviour.
… existing annotation.
cage2
changed the title
- fixed type of second argument calling 'signal' in 'annotate-load-annotation-data'.
|
Hi @bastibe! I am not able to find any other function where adding errors signalling could be useful. Bye! |
bastibe
approved these changes
Aug 11, 2020
added 2 commits
August 11, 2020 16:30
- added docstring to 'annotate-load-annotation-data-ignore-errors'.
|
On Mon, Aug 10, 2020 at 11:49:43PM -0700, Bastian Bechtold wrote:
Hi @bastibe!!
Looks great!
I wonder if it might be better to add an optional `ignore-errors` argument to `annotate-load-annotation-data` instead of creating a new function. This might be a bit more concise.
To be honest as the function
'annotate-load-annotation-data-ignore-errors' is used here and there
in the code, replacing each occurrence of said function with:
(ignore-errors (annotate-load-annotation-data ...
would be not so elegant.
Anyway i left the decision to you, as usual! :)
Bye!
C.
|
|
Sorry for not being precise (again). What I meant was to change the function to and call it variously as But I am entirely OK with the current solution as well. |
Used an optional parameter in 'annotate-load-annotation-data' to ignore the signalled errors instead.
|
On Tue, Aug 11, 2020 at 08:45:36AM -0700, Bastian Bechtold wrote:
Hi Bastibe!!!
Sorry for not being precise (again).
No, it is my fault, your message was very clear, it is me that did not
pay the necessary attention reading it. :(
What I meant was to change the function to
(defun annotate-load-annotation-data (&optional ignore-errors) ...)
and call it variously as `(annotate-load-annotation-data)` or `(annotate-load-annotation-data t)`.
This is a much more elegant solution! :)
Bye!
C.
|
bastibe
approved these changes
Aug 12, 2020
|
Hi bastibe! OK, merging! Thak you for your support! :) Bye! |
|
My pleasure! Thank you for all the hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bastibe!
I am starting to working on what we discussed in #76, adding errors to developers oriented functions. To me the first candidate was the function that load the annotation database from a file.
I am going to add errors one function for commit because i think would be simpler to evaluate the changes.
Bye!
C.