Fixed a regression and some bugs related to incorrect calculation of multiline annotations. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of multiline annotations. To reproduce the bugs: legend: a = annotated text * = non annotated text - First bug Create a multiline annotation using region. aaaa aaaa aaaa #### Place the cursor as below. aaaa ^ cursor aaaa aaaa #### type a character a**** aaaa aaaa #### The annotated text has a "gap" Fix proposed: revert to the old (correct behaviour) Second bug aaaa aaaa aaaa #### Place the cursor as below. aaaa ^ cursor on the first column aaaa aaaa #### type some text *** aaa aaa #### Save (C-x C-s) you get an error on the echo area: "let*: Wrong type argument: overlayp, nil" and the annotations are not correctly saved. Fix proposed: remove the offending code. Third bug a multiline bug as before aaaa aaaa aaaa #### place the cursor here: aaaa aaaa ^ cursor aaaa #### type some text aaaa ***** aaaa #### Then annotate the same line (C-c C-a): aaaa aaaa #### aaaa #### we introduced a annotation in the gap of the already existing multiline annotation. Fix proposed: prevents annotating text inside an annotation.
|
I currently don't have the time to truly look into this, but I trust you completely to do the right thing! |
|
On Mon, Nov 09, 2020 at 01:51:04AM -0800, Bastian Bechtold wrote:
Hi Bastian!
I currently don't have the time to truly look into this,
No problem! Just hope everything is fine.
but I trust you completely to do the right thing!
Thank you! I promise i will do my best! :)
Bye!
C.
|
|
Hi Cage,
We are doing very well, thank you. But we had a new baby a few weeks ago, which leave little room for side projects at the moment. I hope you are doing well also! |
'annotate--position-inside-annotated-text-p'; - fixed some typos.
|
On Wed, Nov 11, 2020 at 12:01:15AM -0800, Bastian Bechtold wrote:
Hi Cage,
Hi!!
> > I currently don't have the time to truly look into this,
> No problem! Just hope everything is fine.
We are doing very well, thank you. But we had a new baby a few weeks ago, which leave little room for side projects at the moment.
My congratulations! So you are starting a new adventure! ;-)
I hope you are doing well also!
I am quite OK, things are getting complicated lately here where i
live, because of the pandemic, but i am still alive in good shape and
confident that everything is going to be alright soon! :)
Bye!
C.
|
|
Hi! I think this PR is ready! I am going to merge it in the next hours. Bye! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bastibe !
I introduced some regression and i failed to manage correctly the multi line annotations. :(
The bugs are too difficult for me to explain so i preferred to add use cases to reproduce the issues and proposed fix. Hope this is OK.
There are some thing still missing in this PR (probably just a couple of docstrings) but the bulk of the fix is here, i submitted this PR now so that maybe some user can test this branch and help with testing and i am going to check later what is missing.
Fortunately seems to me that some of the code here should be useful for #83!
Bye!!
C.