Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update kubernetes installation with multiple solution #782

Merged

Conversation

jplanckeel
Copy link
Contributor

Description

We want add all solution to deploy Homer in kubernetes Dashboard

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link

netlify bot commented May 18, 2024

Deploy Preview for homer-demo-content failed.

Name Link
🔨 Latest commit 5042b02
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/664edb7f285b530008a11c22

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue on the README file but aside from that, it looks good !
Thank you for your contribution @jplanckeel !

README.md Outdated
Comment on lines 47 to 54
/**
* @file README.md
* @brief Table of Contents for the Homer project.
*
* This file contains the table of contents for the Homer project's README.md file.
* It provides an overview of the different sections and links to the corresponding documentation files.
*/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's supposed to be displayed or not but I can see on your repo that it is rendered kinda broken.

I don't think this part is necessary, could you remove it? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it's an involuntary addition, i have remove it ;)

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for improving the documentation !

@bastienwirtz bastienwirtz merged commit e6adfd7 into bastienwirtz:main May 23, 2024
0 of 8 checks passed
@jplanckeel jplanckeel deleted the docs/update-kubernetes-installation branch May 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants