Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeaNUT custom service #826

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

Canti23
Copy link
Contributor

@Canti23 Canti23 commented Nov 14, 2024

Description

Creating custom service for PeaNUT and added documentation.
Allows displaying current status and load:

изображение

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everthing looks good, thanks again @Canti23!

Could you add an example of the api output here: https://github.com/bastienwirtz/homer/tree/main/dummy-data (more detail in the directory readme) ? So it's easily testable and also we can add it to the public demo config.

@Canti23
Copy link
Contributor Author

Canti23 commented Nov 18, 2024

Hi, Thank you for the review
Added demo data

@bastienwirtz
Copy link
Owner

Perfect, thanks!

@bastienwirtz bastienwirtz merged commit fd91907 into bastienwirtz:main Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants