GitHub Action: Super-Linter #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the chmod +x in the Dockerfile is not needed anymore.
The first line isn't a real heading, but making it requires then changing all subsequent headings to a lever deeper. I opted to deactivate the rule. Also remove the space from the link, it isn't needed.
this one might be an overreach, hence the separate commit
standard's settings conflict with what the upstream config.js is, so it's not worth to run it.
but it doesn't make sense, as sooner or later the base image will change to someting newer, and gettext will have a newer version available.
and also add a shebang where previously was none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yo dawg, I heard you like GitHub Actions, so I put more action into your actions. ;)
No, seriously, I thought it would be a nice idea on my docker-vdirsyncer repo, and so I thought I spread a bit further and implement it here too, and fix the issues directly.
So if you think that anything needs to be changed tell me.
Oh: if you want to see the initial complaints take a look at my first run:
https://github.com/klaernie/docker-MagicMirror/runs/1775024591?check_suite_focus=true
The last runs then cleanly: https://github.com/klaernie/docker-MagicMirror/actions/runs/516041132