Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async cluster construction #12

Merged
merged 11 commits into from
Feb 29, 2020
Merged

Async cluster construction #12

merged 11 commits into from
Feb 29, 2020

Conversation

vertexclique
Copy link
Member

Launch and run AP cluster in the async environment.

Copy link
Collaborator

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can enforce the checks in the CI as a followup PR?

@vertexclique
Copy link
Member Author

vertexclique commented Feb 29, 2020

Maybe we can enforce the checks in the CI as a followup PR?

I've just enabled "don't merge if checks won't pass". Isn't it what we want?

@o0Ignition0o
Copy link
Collaborator

I meant the checks in checks.sh, but that’s nice to have as well!

@vertexclique
Copy link
Member Author

Ok, I will do that to run config for checks too. I hate writing YAML. here we go again.

@o0Ignition0o
Copy link
Collaborator

Dw I can pick it up if you assign me, I’ve done Travis ci yml but no gh actions yet !

@vertexclique vertexclique merged commit fe12258 into master Feb 29, 2020
@vertexclique vertexclique deleted the async-cluster-construct branch February 29, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants