Module not working on Windows #30

bajtos · 2014-03-24T14:13:33Z

The HEAD version does not work on Windows 8.1 x64.

$ node tests\test-fs-flock.js
FAILURE: LOCK_EX is not defined correctly
  LOCK_EX    undefined    "undefined"
FAILURE: LOCK_NB is not defined correctly
  LOCK_NB    undefined    "undefined"
FAILURE: LOCK_SH is not defined correctly
  LOCK_SH    undefined    "undefined"
FAILURE: LOCK_UN is not defined correctly
  LOCK_UN    undefined    "undefined"
FAILURE: expect_errno: flockSync(): expected error EBADF, got another error
   ARGS:  { '0': 'flockSync',
  '1': -9,
  '2': [TypeError: Bad argument],
  '3': 'EBADF' }
FAILURE: expect_errno: flockSync(): expected error EBADF, got another error
   ARGS:  { '0': 'flockSync',
  '1': 98765,
  '2': [TypeError: Bad argument],
  '3': 'EBADF' }
FAILURE: expect_ok: flockSync(): returned error
   ARGS:  { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
   ARGS:  { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
   ARGS:  { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
   ARGS:  { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
   ARGS:  { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }

When used in Sinopia, it crashes the whole process. Release build of node v0.10.26 crashes with StackOverflow.

The debug build of node v0.10.26 reports

Unhandled exception at 0x6D5633D1 (fs-ext.node) in node.exe: An invalid parameter was passed to a function that considers invalid parameters fatal.

Stack trace:
    fs-ext.node!_invalid_parameter_noinfo() Line 96 C++
    fs-ext.node!_get_osfhandle(int fh) Line 306 C
    fs-ext.node!_win32_flock(int fd, int oper) Line 196 C++
>   fs-ext.node!EIO_Flock(uv_work_s * req) Line 247 C++

The text was updated successfully, but these errors were encountered:

baudehlo · 2014-03-25T12:51:45Z

Unfortunately I don't have Windows boxes to test/develop on. I'm relying on
the open source community to work on the Windows compatibility.

On Mon, Mar 24, 2014 at 10:13 AM, Miroslav Bajtoš
notifications@github.comwrote:

The HEAD version does not work on Windows 8.1 x64.

$ node tests\test-fs-flock.js
FAILURE: LOCK_EX is not defined correctly
LOCK_EX undefined "undefined"
FAILURE: LOCK_NB is not defined correctly
LOCK_NB undefined "undefined"
FAILURE: LOCK_SH is not defined correctly
LOCK_SH undefined "undefined"
FAILURE: LOCK_UN is not defined correctly
LOCK_UN undefined "undefined"
FAILURE: expect_errno: flockSync(): expected error EBADF, got another error
ARGS: { '0': 'flockSync',
'1': -9,
'2': [TypeError: Bad argument],
'3': 'EBADF' }
FAILURE: expect_errno: flockSync(): expected error EBADF, got another error
ARGS: { '0': 'flockSync',
'1': 98765,
'2': [TypeError: Bad argument],
'3': 'EBADF' }
FAILURE: expect_ok: flockSync(): returned error
ARGS: { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
ARGS: { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
ARGS: { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
ARGS: { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }
FAILURE: expect_ok: flockSync(): returned error
ARGS: { '0': 'flockSync', '1': 3, '2': [TypeError: Bad argument] }

When used in Sinopia https://github.com/rlidwka/sinopia, it crashes the
whole process. Release build of node v0.10.26 crashes with StackOverflow.

The debug build of node v0.10.26 reports

Unhandled exception at 0x6D5633D1 (fs-ext.node) in node.exe: An invalid parameter was passed to a function that considers invalid parameters fatal.

Stack trace:
fs-ext.node!_invalid_parameter_noinfo() Line 96 C++
fs-ext.node!_get_osfhandle(int fh) Line 306 C
fs-ext.node!_win32_flock(int fd, int oper) Line 196 C++

fs-ext.node!EIO_Flock(uv_work_s * req) Line 247 C++

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/30
.

bajtos · 2014-03-25T13:47:41Z

Unfortunately I don't have Windows boxes to test/develop on. I'm relying on
the open source community to work on the Windows compatibility.

Sure. My primary motivation was to record the problem, so that other people can find this issue when troubleshooting Sinopia or fs-ext on Windows.

@piscisaureus and me spent some time tracking down the issue, but were not able to pin down the root cause yet. One possible reason may be duplication of the fd->osfhandle table between Node core and the native module. I'll post an update if we find anything more.

winnetou1357 · 2014-05-15T12:32:45Z

The failure is that the names LOCK_EX, LOCK_SH, LOCK_NB and LOCK_UN are accidentally defined as const ints, while NODE_DEFINE_CONSTANT calls are guarded with #ifdefs for these names. See fs-ext.cc:76 and fs-ext.cc:455
Now the code compiles gracefully, but any call to flock result in a TypeError with the message "Bad argument", because stringToFlockFlags converts anything to undefined.

@baudehlo I would willingly make a pull request for it but I'm not familiar with git and github anyway. I plan to learn it soon, but until that, feel free to fix this issue.

baudehlo · 2014-05-15T13:08:37Z

I don't have windows to test against so a pull request would be preferable.

On May 15, 2014, at 8:32 AM, winnetou1357 notifications@github.com wrote:

The failure is that the names LOCK_EX, LOCK_SH, LOCK_NB and LOCK_UN are accidentally defined as const ints, while NODE_DEFINE_CONSTANT calls are guarded with #ifdefs for these names. See fs-ext.cc:76 and fs-ext.cc:455
Now the code compiles gracefully, but any call to flock result in a TypeError with the message "Bad argument", because stringToFlockFlags converts anything to undefined.

@baudehlo I would willingly make a pull request for it but I'm not familiar with git and github anyway. I plan to learn it soon, but until that, feel free to fix this issue.

—
Reply to this email directly or view it on GitHub.

bajtos · 2014-05-15T14:02:00Z

I have submitted a pull request fixing the constant vs. macro problem.

Now the flock test node tests\test-fs-flock.js silently crashes, which is the real problem and much more difficult to solve. As I said in a previous comment, it's possible the duplication of the fd->osfhandle table between Node core and the native module is broken on Windows. The issue is hard to debug, as the Node runtime tends to crash on a different thing when the test is run in a native VisualStudio debugger.

bajtos · 2014-05-15T14:08:41Z

@baudehlo

I don't have windows to test against so a pull request would be preferable.

FWIW, you can download a Windows image for VirtualBox (or other VM host) for free at
http://www.modern.ie/en-us/virtualization-tools#downloads

tracker1 · 2014-10-23T18:59:35Z

@baudehlo to add to what @bajtos pointed to...

Visual Studio Express 2013
Using VS2013 Express with Platform SDK
Platform SDK (search, match the windows version)

If I had a better understanding of C/C++, I'd love to help with this... since this level of locking (and the need for range locking) are kind of important to me... as it is, I'm shimming the functionality I need via edge which works, but is not as lean as I'd really like it to be.

baudehlo · 2014-10-23T19:03:42Z

Sadly those don't work on Macs :) And my main dev machine at home isn't
powerful enough to run VMs.

On Thu, Oct 23, 2014 at 2:59 PM, Michael J. Ryan notifications@github.com
wrote:

@baudehlo https://github.com/baudehlo to add to what @bajtos
https://github.com/bajtos pointed to...

Visual Studio Express 2013
http://www.visualstudio.com/downloads/download-visual-studio-vs#d-express-web
Using VS2013 Express with Platform SDK
http://msdn.microsoft.com/en-US/library/ms235626(v=vs.80).aspx
Platform SDK (search, match the windows version)
http://www.microsoft.com/en-us/search/result.aspx?q=platform%20sdk%20windows%207

If I had a better understanding of C/C++, I'd love to help with this...
since this level of locking (and the need for range locking) are kind of
important to me... as it is, I'm shimming the functionality I need via
edge https://www.npmjs.org/package/edge which works, but is not as lean
as I'd really like it to be.

—
Reply to this email directly or view it on GitHub
#30 (comment).

tracker1 · 2014-10-24T04:26:11Z

VirtualBox doesn't work on Mac?

baudehlo · 2014-10-24T13:09:15Z

Yes it does, but I only have 2G of ram at home. I have plenty on my dev
machine at work, but no time (or reason for the company to need it) to do
the work there.

On Fri, Oct 24, 2014 at 12:26 AM, Michael J. Ryan notifications@github.com
wrote:

VirtualBox doesn't work on Mac?

—
Reply to this email directly or view it on GitHub
#30 (comment).

simonhoss · 2014-10-29T08:10:37Z

Hi,

I found the problem. The problem is that fs-ext tries to open an invalid file descriptor (EBADF). So I made a fix that node does not crash, when this happens. But I cannot resolve why the handle is invalid. Any ideas?

Here is my test code:

var fsExt = require("./fs-ext");
var fs = require("fs");
fs.open("D:/test/test.txt", "r", function(err, fd) { 
  fsExt.flock(fd, 6, function(test) { console.log(test); });
});

bajtos · 2014-10-29T08:25:29Z

@simonhoss See my comment above. The problem seems to be caused by the way how Node.js works with Windows file handles, where the handles seem to be unavailable to native addons. As I mentioned earlier, I was debugging this with Bert, who wrote most of the Windows-specific code in Node.js core, and even he could not track down the source of the problem in a reasonably short time.

simonhoss · 2014-10-29T08:36:49Z

Ok. So then I make a pull request that node does not crash and brings a EBADF error message. #36

baudehlo · 2015-02-27T17:04:57Z

I'm closing this issue now due to the merged pull requests. Please re-open if it's still an issue.

bajtos · 2015-02-27T18:54:14Z

I don't think #36 fixed the problem, see my comment: #36 (comment).

However, since there was nobody else complaining about the Windows support in the last three months or so, I think it's ok to keep this issue closed.

bajtos mentioned this issue Mar 24, 2014

Does not work on Windows rlidwka/sinopia#61

Open

bajtos mentioned this issue May 15, 2014

win32: Replace LOCK_* constants with macros #31

Merged

This was referenced Oct 29, 2014

Total crash on Windows 7. rlidwka/sinopia#138

Open

seek doesn't work on Windows #34

Closed

bajtos mentioned this issue Dec 15, 2014

add flock API to fs module nodejs/node#122

Closed

baudehlo closed this as completed Feb 27, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Module not working on Windows #30

Module not working on Windows #30

bajtos commented Mar 24, 2014

baudehlo commented Mar 25, 2014

bajtos commented Mar 25, 2014

winnetou1357 commented May 15, 2014

baudehlo commented May 15, 2014

bajtos commented May 15, 2014

bajtos commented May 15, 2014

tracker1 commented Oct 23, 2014

baudehlo commented Oct 23, 2014

tracker1 commented Oct 24, 2014

baudehlo commented Oct 24, 2014

simonhoss commented Oct 29, 2014

bajtos commented Oct 29, 2014

simonhoss commented Oct 29, 2014

baudehlo commented Feb 27, 2015

bajtos commented Feb 27, 2015

Module not working on Windows #30

Module not working on Windows #30

Comments

bajtos commented Mar 24, 2014

baudehlo commented Mar 25, 2014

bajtos commented Mar 25, 2014

winnetou1357 commented May 15, 2014

baudehlo commented May 15, 2014

bajtos commented May 15, 2014

bajtos commented May 15, 2014

tracker1 commented Oct 23, 2014

baudehlo commented Oct 23, 2014

tracker1 commented Oct 24, 2014

baudehlo commented Oct 24, 2014

simonhoss commented Oct 29, 2014

bajtos commented Oct 29, 2014

simonhoss commented Oct 29, 2014

baudehlo commented Feb 27, 2015

bajtos commented Feb 27, 2015