#98 - Fix native worker compatibility

[Fordi]

Fixes: #98

This PR modifies the node module initialization to give it minimal context-awareness, such that it can work within a node:worker_threads worker.

See: https://github.com/nodejs/node/blob/main/doc/api/addons.md#context-aware-addons

[Fordi]

Note: NODE_MODULE_INIT uses NODE_GYP_MODULE_NAME as an identifier, so this must be a valid identifier.

[Fordi]

Build was failing with nan 2.14.

[Fordi]

@baudehlo hey, not to be a noodge, but have you had a chance to look at this?

[baudehlo]

I haven't - someone else took over maintenance of this module, but maybe they are awol now. It looks fine, and I'm happy to merge.

…

On Wed, Oct 23, 2024 at 10:52 AM Bryan Elliott ***@***.***> wrote: @baudehlo <https://github.com/baudehlo> hey, not to be a noodge, but have you had a chance to look at this? — Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFBWYYVG37V76ZPW7NNHRDZ46Z4HAVCNFSM6AAAAABPXL4TFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSGQ4TQNRUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Fordi]

Been a week, the maintainer hasn't responded. Please merge.

[baudehlo]

I merged it, but I've been trying to add Actions tests (it was originally setup using Travis), and the tests don't pass: #110

[Fordi]

Haha. Mandatory, "it works on my local".

I'll have a look and see if I can figure out what's going wrong.

[Fordi]

Ah. Run git pull --rebase origin master on your patch branch. The fs-ext.cc in there still has NODE_MODULE at the bottom, not NODE_MODULE_INIT. I'll comment the same on your PR.