Skip to content

Conversation

okyska
Copy link
Collaborator

@okyska okyska commented Oct 17, 2017

added fields in user.properties
created EsspressoSignInTest class
added test logInAndBankAccount

Copy link
Collaborator

@booorisss booorisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your new test is correct, however it breaks previous test. Cannot approve

new ActivityTestRule<>(SplashActivity.class, false, true);

@Test
public void userSignInPersonalInfoRequiredFieldsAreRequired(){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, your logic breaks this test! You are doing Sign In in Before annotation , and this test requires no sign in ( this is negative sign in test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants