Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Keyword-Arguments in Dispatch and Sampling #248

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

LarsKue
Copy link
Contributor

@LarsKue LarsKue commented Nov 12, 2024

No description provided.

@LarsKue LarsKue marked this pull request as ready for review December 3, 2024 15:07
@LarsKue LarsKue requested a review from stefanradev93 December 3, 2024 15:07
@vpratz
Copy link
Collaborator

vpratz commented Dec 13, 2024

Bumping this. As it was requested and tested in #266 and seems to work, it would be great to have this merged soon. @stefanradev93, do you have capacity to review this or should I try to make a review?

@stefanradev93
Copy link
Contributor

Hey Valentin, I would appreciate it if you could review and merge the PR!

@stefanradev93 stefanradev93 requested a review from vpratz December 13, 2024 15:08
@vpratz vpratz removed the request for review from stefanradev93 December 20, 2024 11:17
@vpratz
Copy link
Collaborator

vpratz commented Dec 20, 2024

Looks good to me. Thanks for implementing those changes!

@vpratz vpratz merged commit 8a870c0 into dev Dec 20, 2024
12 of 13 checks passed
@vpratz vpratz deleted the forward-kwargs branch December 20, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants