Skip to content

correct the formatting for positive numbers with negative exponents and add additional test #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2025
Merged

correct the formatting for positive numbers with negative exponents and add additional test #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ff0b5
correct the formatting for positive numbers with negative exponents a…
adrianmolzon Aug 28, 2025
006b979
add case for negative exponent truncation, add guard for the mantissa
adrianmolzon Aug 28, 2025
4df7b26
delete unnecessary else statement
adrianmolzon Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions bayes_opt/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _format_number(self, x: float) -> str:
result = ""
width = self._default_cell_size
# Keep negative sign, exponent, and as many decimal places as possible
if "-" in s:
if x < 0:
result += "-"
width -= 1
s = s[1:]
Expand All @@ -96,8 +96,6 @@ def _format_number(self, x: float) -> str:
width -= dot_pos
if width > 0:
result += s[dot_pos : dot_pos + width]
else:
result += s[:width]
if "e" in s:
result += end
result = result.ljust(self._default_cell_size)
Expand Down
9 changes: 8 additions & 1 deletion tests/test_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,14 @@ def test_format_number():
assert len(formatted) == logger._default_cell_size
assert formatted == "1.234e+13"

# Test negative scientific notation truncation
sci_float = 1.11111111e-5
formatted = logger._format_number(sci_float)
assert formatted == "1.111e-05"

sci_float_neg = -1.11111111e-5
formatted = logger._format_number(sci_float_neg)
assert formatted == "-1.11e-05"

sci_float = -12345678901234.5678901234
formatted = logger._format_number(sci_float)
assert len(formatted) == logger._default_cell_size
Expand Down